Martin Auswöger
Martin Auswöger
Possibly a duplicate of #75 ?
We should test if this also works with MySQL 8, as their docs say: _“In MySQL 8.0.22 and later, use of a binary string with any of the MySQL regular...
@bezin is this pull request completed apart from the `sanitize_html` filter? ~~Should I create a pull request on your pull request that adds the `sanitize_html` filter?~~ https://github.com/bezin/contao/pull/7
As discussed in the call today we want detect and normalize accordingly.
> I was wondering if we should limit adding URIs to the front end? I think even in the backend the URL can be very helpful for debugging purposes.
This should be ready for review now. An insert tag in the new system now looks like this: ```php class MyInsertTag { #[AsInsertTag('my_tag')] public function __invoke(ResolvedInsertTag $insertTag): InsertTagResult { return...
> Just to clarify: if you override an Insert Tag with a higher priority this way, the original Insert Tag resolver will not be executed at all, correct? If you...
> I still feel like we should use interfaces, since the insert tags expect certain parameters (`AsBlockInsertTag` expects two specific parameters for example) and need to return a certain type....
> What if, for DX sake, we simply add an `AbstractInsertTagResolver` and `AbstractBlockInsertTagResolver` which you can optionally use? I added the interfaces `InsertTagFlagInterface`, `InsertTagResolverNestedParsedInterface`, `InsertTagResolverNestedResolvedInterface`, `BlockInsertTagResolverNestedParsedInterface` and `BlockInsertTagResolverNestedResolvedInterface` in 711b54d285c1cc1eb5a5a001fadec11ced477a06.
As discussed today, we want to adjust the logic to what was outlined by @CMSworker in https://github.com/contao/contao/issues/4476#issuecomment-1360173736