Augustine Kim

Results 141 comments of Augustine Kim

The `page.js` doesn't actually look wrong. It seems `@lit-labs/ssr-client` is resolving to the dev version. Looking back at the original error you're getting, the mixup is likely due to `lit-html`,...

Thank you, that's excellent sleuthing! So even the unsafehtml in that case is problematic because the fact that it's logging anything means it would've hit the throw line. But seeing...

I don't think it's a different version problem, but might be due to how nextjs is bundling deps, or could also be a bug in how the directive patching for...

The rationale for preserving last successful value is compelling to me. I wonder if it's good to just change the behavior (might be considered breaking), or make the behavior opt-in...

With playwright, the browser version is tied to playwright version and is not configurable. https://playwright.dev/docs/browsers You can see what browser versions come with playwright in their release note https://playwright.dev/docs/release-notes#browser-versions To...

Also costs $ and will require some approval process. Unsure if legal needs to be involved if we want to apply for the open source license for either BrowserStack or...

Indeed this was the idea as we were adding the init command but the trouble is figuring out how much to include and how configurable it will be. It will...

This is a good observation/report, and due to a fundamental difference in how we treat "default" values in `LitElement`. The "default" are really just _initial_ values set on element construction...

Another workaround on the consumer side without modifying the wrapper generator code is to simply wrap it with another React component that defaults the prop like this: https://codesandbox.io/p/sandbox/falling-rain-vw3cww?file=%2Fsrc%2FMyComponentWrapped.tsx

Indeed consumer wrapper would also need to use `forwardRef`. I updated the sandbox https://codesandbox.io/p/sandbox/falling-rain-vw3cww?file=%2Fsrc%2FMyComponentWrapped.tsx The use of `static defaultProps` is also how React class components do it. We're probably not...