Augustine Kim
Augustine Kim
Can we add https://github.com/lit/lit/pull/3693 to 3.0?
@raoufswe Regarding update 3, the problem with doing that would be that you won't get the production version when you need it. I'm curious if `yarn build && yarn start`...
I'm seeing this in a different project with npm. I'll have to investigate further. Something about the `next` cli running in dev mode is not bringing in the correct export...
This is just the behavior of `URL`. You're grabbing the `.href` which in Node will be the file url. If you know what the relative path to your asset should...
Here are some findings after investigating. The `@lit-labs/context` decorators make use if `decorateProperty()` https://github.com/lit/lit/blob/a1f8c345cc978be06c6416edd1228fc5471c53d8/packages/reactive-element/src/decorators/base.ts#L63 When this is used without providing a `descriptor` and only `finisher` as it is done with...
Which one is the "surrounding element" you speak of? I'm guessing the component where this snippet of template is being rendered. I suppose the default calling behavior of event listeners...
@rschristian The change you proposed of updating return type of `FunctionComponent` to include `ComponentChild` does work but only on TS >= 5.1 due to this change https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-1.html#decoupled-type-checking-between-jsx-elements-and-jsx-tag-types What's considered a...
Ah this appears to have been visited before: https://github.com/preactjs/preact/issues/3611 It was just ahead of its time. Is forking the type so bad? It's unfortunate that TS only recently made it...
As noted in the comment in https://stackoverflow.com/q/77865115/19498660 the thing that stands out is the placement of the decorator on the getter rather than the setter. Based on the error message,...
If you're using decorators with Babel, see https://lit.dev/docs/components/decorators/#decorators-babel The Lit 3 upgrade guide's section on standard decorators may also be helpful https://lit.dev/docs/releases/upgrade/#standard-decorator-migration