Augustine Kim

Results 141 comments of Augustine Kim

The PR mentioned above has made its way to a stable release so closing this as fixed!

I have the same issue: Pocket Casts v7.58.0.3 iPhone 15 Pro iOS 17.4 (21E219) Apple Watch Series 9 watchOS 10.4 (21T216) I originally thought having the app installed on my...

@foadtkf support for app router is tracked in a separate issue https://github.com/lit/lit/issues/3657

Supporting v14 seems a bit more complicated as they're now bundling `react/jsx-dev-runtime` and `react/jsx-runtime` rather than it being external for us to use the normal module replacement plugin. See https://github.com/vercel/next.js/discussions/46470#discussioncomment-8375627...

Found a way to monkey-patch everything without resorting to module replacement in above linked PR.

The error appears to stem from trying to patch `React.createElement`. https://github.com/preactjs/signals/blob/d7f2afafd7ce0f914cf13d02f87f21ab0c26a74b/packages/react/runtime/src/auto.ts#L371 There seems to be some inconsistent behavior on webpack module resolution with ES module interop in how `import React...

Thank you for the report! This is indeed the case. I'm not sure I'd consider this a bug. As you've noted, there's no adverse effect and the latter rule will...

`app` directory support definitely looks worthwhile to pursue. It does appear that something with the App router breaks Declarative Shadow DOM parsing even for browsers that should support it, so...

@datradito sorry I haven't gotten around to investigating fully yet as we've been focused on other things for the Lit 3.0 release. I can't say for sure when I'll get...

Oof.. it seems maybe they're doing es modules so monkey patching `React.createElement` doesn't work.