angular-cli icon indicating copy to clipboard operation
angular-cli copied to clipboard

Update defaults for guards and resolvers to be functional guards

Open atscott opened this issue 2 years ago • 1 comments

first two commits are part of https://github.com/angular/angular-cli/pull/24170.

The two commits specific to this are the default updates, which may be considered a breaking change.

atscott avatar Nov 03 '22 20:11 atscott

Hi @atscott,

We did discuss this PR during our last triage meeting and while we do not guarantee that the generated code does not change between versions. This is too big of a change to be done outside of a major.

We suggest a call out in the deprecation note so users can opt-in and use the non deprecated code template by default

ng config schematics.@schematics/angular:guard.functional true
ng config schematics.@schematics/angular:resolver.functional true

Feel free to close the PR or rebase it and make the necessary changes to eventually land in v16. I also have a separate PR to add an aliased for the implements flag https://github.com/angular/angular-cli/pull/24216

alan-agius4 avatar Nov 24 '22 12:11 alan-agius4

Closing in favor of https://github.com/angular/angular-cli/pull/24585

alan-agius4 avatar Jan 20 '23 14:01 alan-agius4

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.