Andreas Süßenbach

Results 120 comments of Andreas Süßenbach

Ok, it's in the raygen shader: `layout(binding = 1, set = 0, rgba8) uniform image2D image;` And apparently, there's nothing like a `bgra8` for the layout. That is, one would...

Could you please provide some images without and with your proposed changes?

> I'd prefer using shaderStorageImageRead/WriteWithoutFormat and the GL_EXT_shader_image_load_formatted GLSL extension. But it would require support of that extension. I don't know anything about its availability. Besides that, is `BGRA8` in...

Would it require something more than just requesting that `shaderStorageImageWriteWithoutFormat` feature? If I request that in `request_gpu_features` like so: ``` if (gpu.get_features().shaderStorageImageWriteWithoutFormat) { gpu.get_mutable_requested_features().shaderStorageImageWriteWithoutFormat = VK_TRUE; } else { throw...

... and requesting both, `shaderStorageImageReadWithoutFormat` and `shaderStorageImageWriteWithoutFormat` doesn't resolve that warning either.

> What shader language are you using? GLSL, HLSL or Slang? I'm using the default, which I think is GLSL.

@SaschaWillems I think, it's easier, when you craft a PR to resolve that issue using those features?

> The default templates that are used when you create a new sample via our scripts include rendering the UI. @gpx1000 Maybe it's worth to recreate these very minimalistic samples...

> Would it be okay for us to do this in a follow patch when all samples are merge, just so our fork doesn't diverge too much? Sure, no problem.

Regarding all those exceptions: I don't think, it's the right approach to use exceptions for non-exceptional cases. You could instead just use `std::filesystem::exists()` to check if the cached file exists....