Andreas Süßenbach
Andreas Süßenbach
Is there a reason you want to rework the readme?
You're more than welcome to rework the readme! I'm pretty sure, any change will be an improvement.
Actually, I'd be fine with any of the proposed names. I had switched to `vulkan_hpp` to be "closer" to the project's name, Vulkan-Hpp. But as @M2-TE said: "C does not...
Could you please check what you get when you change that line 89 in samples/SharedHandles/SharedHandles.cpp to ` vk::SharedSurfaceKHR sharedSurface{ static_cast(surface), instance }; `
Where have all the tests gone? In VS I just have the `UniqueHandle` test, that's all.
Having CTests would be cool. But not having the test files available in the VS solution feels wrong. Can't we have both, CTest and files listed in VS? If that's...
It seems, you're running this PR on a slightly outdated Vulkan-Headers version. Would be great, if you'd rebase it accordingly.
> > I would simply exclude the module-related things from CI. Is that acceptable or should I tear these apart on a deeper level? > > I think just having...
> It should be on the newest version You're right. Don't know what I've seen before. Sorry, please.
I can confirm, with SDK 1.3.296.0 this issue is resolved.