Thomas Robitaille

Results 891 comments of Thomas Robitaille

Sorry for dropping the ball on this, could you rebase to pick up the latest CI?

Just for the record, I have been in touch with folk at SKAO HQ at Jodrell Bank and they have also expressed interest in hosting it. I have more details...

I think we should definitely do this before the next coordination meeting. This could just be an especially organized remote event?

Should be fixed in pyregion 2.3.0 (just released)

@dhomeier - would you like to review this? I've had confirmation from the jdaviz side that it works for them.

@rosteen - I have now added some changes to make sure that we delay any subset creation or deletion messages until the subset has been defined or removed from all...

@dhomeier sounds good, could you push your test as a commit to this PR?

@dhomeier - I think that error makes sense once the subset is removed as there should no longer be any subsets. Maybe you should have an ``if len(data1.subsets) > 0``...

@dhomeier - yes, we should first merge this and then do a release and only then switch over in glue-qt.