Thomas Robitaille comments

Results 891 comments of


                                            Thomas Robitaille

Add option to limit the number of lines used for guessing in io.ascii

@taldcroft @mhvk - I've now implemented your comments/suggestions related to this PR, and it is now ready for a proper review

Add option to limit the number of lines used for guessing in io.ascii

Ok sounds good, I'll try and work on this some more!

Add option to limit the number of lines used for guessing in io.ascii

@taldcroft - comments implemented and rebased

Add option to limit the number of lines used for guessing in io.ascii

@taldcroft - I realised that ``table`` can also be a list of strings or a file object. I have fixed the easy case where it is a list of lines,...

Add option to limit the number of lines used for guessing in io.ascii

@taldcroft - I've skipped the limit limiting now for file objects. I ran into issues when trying to add a test for this because it seems that even something simple...

Add option to limit the number of lines used for guessing in io.ascii

We should probably check that and raise a more explicit error though right? Is there no way we could support files opened with r?

Truncate exception message from `Latitude._validate_angles` to readable size

This PR is helpful and needed, so will re-open and rebase!

Truncate exception message from `Latitude._validate_angles` to readable size

I pushed a commit to address @mhvk's two small nitpicks

Verify correctness of derivatives of all models

If I change the atol to 0.001 in ``test_deriv_1D`` the only model other than Lorentz1D that fails on the last stable release is ``KingProjectedAnalytic1D`` so that may be the next...

Compound models use excessive memory

I think it might make sense to consider, at least for the additive case, a separate compound class that has a 'flat' structure, i.e. internally just has a list of...