Anshul Singhvi

Results 1166 comments of Anshul Singhvi

Hmm, do `Begin` and `End` work with regular abstract arrays as well? That would be pretty interesting to have for me - wouldn't want to accidentally use the wrong thing...

Iterating out of order is fine, but a `readblock` on every iteration is probably pushing it :D

There might be some type instability as well, will have to profile with Cthulhu. But AccessCountDiskArray is showing the correct number of accesses via `map`, so it should be fine....

Here's another example with `collect`: ```julia julia> da = AccessCountDiskArray(data, chunksize=(10,10)) 200×100 AccessCountDiskArray{Int64, 2, Matrix{Int64}, DiskArrays.ChunkRead{DiskArrays.NoStepRange}} Chunked: ( [10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10,...

There are also situations where people encode noninvertible transforms (or at least transforms for which `Makie.inverse_transform` is not defined), so we should make sure that all the axis interactions at...

I think we still don't forward a bunch of stuff (`isdisk` etc). Should we do that?

I like the design but not a huge fan of the colors 😅 - are they open to change?

Could you post the script you used to generate it? (assuming this was with Makie.voxels but may be wrong)

These seem a bit inscrutable - are they terminal codes? https://github.com/rafaqz/DimensionalData.jl/blob/5caae5792cc969bf97756fae8eddc8420e2618e6/src/Dimensions/show.jl#L11-L13 Ah they are, here are the first five: ```julia using Colors [colorant"#ff875f", colorant"#0087d7", colorant"#5fd7ff", colorant"#ff5f87", colorant"#b2b2b2"] ```