Anshul Singhvi comments

Results 1165 comments of


                                            Anshul Singhvi

Define crstrait if available

bump @evetion - is this good to go from your end?

`findmax` does not work on DimStacks

btw, I don't need this, just an edge case I stumbled into.

Allow GLMakie to display surfaces transformed by a 3d transform func

Bump @SimonDanisch, could this be reviewed? Thanks :D

Improve CairoMakie's 2D mesh performance

Agreed, may as well merge. Will wait for the GeometryBasics refactor before pushing more on this! (And in the worst case, we can just switch all meshes to the 3d...

Improve CairoMakie's 2D mesh performance

WGLMakie failures are because the texture atlas is slightly larger than expected: ```julia session_size = 6.095909 texture_atlas_size = 6.095909 memory leaks: Test Failed at /home/runner/work/Makie.jl/Makie.jl/WGLMakie/test/runtests.jl:57 Expression: texture_atlas_size < 6 Evaluated:...

Make `VideoStream` aware of `px_per_unit`

Probably, I haven't run into it again

Strange behaviour where `crop` is cropping too much

This might be the same problem as #751, but in a different place...

Strange behaviour where `crop` is cropping too much

Oops...edited, thanks. It's a zeroed out array with that Extent.

Allow renderers to override `_any_color_fmt`.

Thanks for the feedback! I would love to make this a public API - if so, it would probably go in `Documenter.Writers`, and perhaps the name `supports_ansicolor` would work? That...

Allow renderers to override `_any_color_fmt`.

Things should be working after this commit.