Arvid Norberg comments

Results 1037 comments of


                                            Arvid Norberg

seperate plot 4 phases to phase1 and phase234

a few high-level comments: * It would be much easier to review if you would not make formatting changes in this PR, but propose those separately * I think we...

Update pos_constants.hpp

looks good to me, but I'd like to defer approval to someone who knows where that limit comes from.

indeed. it seems we would need [this](https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/setmaxstdio?view=msvc-160) for windows. > C run-time I/O now supports up to 8,192 files open simultaneously at the low I/O level. This level includes files...

Common template for inline vector implementation.

this mostly looks like an improvement. However, when you make the element type a template argument I think you're going a bit too far. your `InlineVector` implementation does not support...

Common template for inline vector implementation.

I think everything looks good apart from my last comment

Fix infinite copy attempts when tmp and final dir are the same, but different

perhaps this is a dumb question, but wouldn't it be a lot simpler and more robust to just rename the file, and if that fails, we can assume the files...

fix data race in blake3's get_cpu_features()

this is a bit more complex than I expected, since both MacOS and ManyLinux lack support for C11 threads functions (specifically, `call_once()`). This could be made to use the posix...

fix data race in blake3's get_cpu_features()

I'm not sure you should have landed this. CI was still half-red

Allow limiting number of plotting processes during Stage 1

I would expect that setting the priority to the threads really low (or high nice-level) would also solve this problem, or at least mitigate it. Have you tested that? If...