chiapos icon indicating copy to clipboard operation
chiapos copied to clipboard

fix data race in blake3's get_cpu_features()

Open arvidn opened this issue 3 years ago • 5 comments

details posted here: https://github.com/BLAKE3-team/BLAKE3/issues/220

arvidn avatar Jan 13 '22 17:01 arvidn

this is a bit more complex than I expected, since both MacOS and ManyLinux lack support for C11 threads functions (specifically, call_once()). This could be made to use the posix threading API. It seems MSVC is also lacking support for C11 threads though.

arvidn avatar Jan 14 '22 14:01 arvidn

'This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed.'

github-actions[bot] avatar Mar 16 '22 11:03 github-actions[bot]

I'm not sure you should have landed this. CI was still half-red

arvidn avatar Mar 28 '22 23:03 arvidn

It hasn't been landed yet - just reviewed.

hoffmang9 avatar Mar 28 '22 23:03 hoffmang9

'This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed.'

github-actions[bot] avatar May 28 '22 11:05 github-actions[bot]

this has been addressed upstream

arvidn avatar Oct 21 '23 20:10 arvidn