Arvid Norberg

Results 1037 comments of Arvid Norberg

> @arvidn I've added simple test code which confirms that wasm runs successfully on NodeJS runtime context. `wasm/tests/index.js` is the one. This test also runs on CI (`build_create-and-npm.yml`). If the...

interestingly, there seems to be a rule preventing building the FFI layer on windows: https://github.com/Chia-Network/clvm_rs/runs/4189087870?check_suite_focus=true#step:7:104 That probably has to be addressed before we can try to get MPIR working.

looks good to me. It needs to be coordinated with https://github.com/Chia-Network/chia-blockchain/pull/11750 though.

right. running the `clvm` tests still depend on `clvm_tools` though. I think long term, those test cases should be executed in a more direct way, that doesn't go through `brun`....

I don't see the value in tying `clvm_rs` together with `clvm`. We don't really need to ensure they move in lock step anymore, do we? e.g. the `op_div` softfork hasn't...

I think it makes sense to remove `deserialize_and_run_program2`, yes. Is it typical python practice to return a "variant" object like that? does the caller need to use `type(cost_or_message)` to know...

the `Bytes32` type seems to be very similar to the one in `chia_rs`. perhaps some types from there should be moved into `clvm_rs`. Or treehash should be moved to `chia_rs`...

@richardkiss Please add a description to this PR. Thins that aren't obvious to me are: 1. what are all the new dependencies for? Are they all transitive dependencies from bumping...

It seems likely that we would get more savings by applying this compression at the db layer and leave the farmed blocks as they are. * We wouldn't have to...

this error is legit. The conversion function from `ErrorCode` to a plain integer also has to be changed to `u16`. https://github.com/Chia-Network/clvm_rs/runs/5277635568?check_suite_focus=true#step:6:82