Common template for inline vector implementation.

[lemur73]

Allows simplier using inline vectors of different sizes and types.

Signed-off-by: Ostap Slavking [email protected] If you like my commits cheer me with some chia here: xch16es77qggpwgzucqmmvhvgcueckmt9g3e7exa46vhmucz7z8j2a2spm7c7e

[lgtm-com[bot]]

This pull request fixes 1 alert when merging 51a5eee10207dd9d6363321484fb1dc79ea28894 into 632c9d70e865f2fdb92c47e4ed3380b5bf92947e - view on LGTM.com

fixed alerts:

• 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')

[lgtm-com[bot]]

This pull request fixes 1 alert when merging 9fa9f9f90f55383cab4f3f24f2b16367ea52b843 into 632c9d70e865f2fdb92c47e4ed3380b5bf92947e - view on LGTM.com

fixed alerts:

• 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')

[arvidn]

this mostly looks like an improvement. However, when you make the element type a template argument I think you're going a bit too far. your InlineVector implementation does not support arbitrary element types. Fortunately, we don't need arbitrary types. I would suggest just leaving it hard coded as uint64_t.

One thing these classes need more urgently are tests though.

[lemur73]

this mostly looks like an improvement. However, when you make the element type a template argument I think you're going a bit too far. your InlineVector implementation does not support arbitrary element types. Fortunately, we don't need arbitrary types. I would suggest just leaving it hard coded as uint64_t.

Well, I have some use of this template argument in my next commits. Just prefer to keep uploads smaller to make it easy to understand and review.

One thing these classes need more urgently are tests though.

I'll upload tests.

[lgtm-com[bot]]

This pull request introduces 1 alert and fixes 1 when merging e94cf3f81e6df7a990b419c580725bd83be4eaf9 into 632c9d70e865f2fdb92c47e4ed3380b5bf92947e - view on LGTM.com

new alerts:

• 1 for Comparison of narrow type with wide type in loop condition

fixed alerts:

• 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')

[lgtm-com[bot]]

This pull request fixes 1 alert when merging 8c6700492404b356f29e2e52a2b25903996090ac into 632c9d70e865f2fdb92c47e4ed3380b5bf92947e - view on LGTM.com

fixed alerts:

• 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')

[lgtm-com[bot]]

This pull request fixes 1 alert when merging c71e3ebdc5c8aedc8e0e3f5eb5b2df08ebf67061 into 632c9d70e865f2fdb92c47e4ed3380b5bf92947e - view on LGTM.com

fixed alerts:

• 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')

[arvidn]

I think everything looks good apart from my last comment

[github-actions[bot]]

'This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed.'