Erik Arvidsson

Results 57 comments of Erik Arvidsson

If you use flow to define the type of the props you should be fine. Adding support for reacts old propTypez API sound useful too. Maybe you could take a...

Using a generator is a great idea. At least if you output generators. If you transform generators to ES5 code then the generated code would be pretty ugly.

I'm not sure what problem we are trying to solve here? How is ``` js local.import("./foo.js").then((def, named) => ...) ``` better than: ``` js local.import("./foo.js").then({default: def} => ...) local.import("./foo.js").then({foo} =>...

Writing `__proto__` in a Google Doc crashed the app at one point in time. Also `hasOwnProperty` has been known to cause issues since people sometimes write: ```js var hash =...

I would expect this to be global, just like the `eslintrcPath` and `eslintRulesDirs` and have to have absolute paths. The path inside the `ignore-path` would probably be relative to the...

Our precommit runs something like: ``` eslint --config= --ignore-path= --rulesdir= ... ``` AtomLinter/linter-eslint supports both `config` and `rulesdir` but not `ignore-path` which leads to lots of false positives when editing...

@mnieper Trying to clean up our parser a bit and the `YieldExpression` probably needs a `[In]` there to allow: ``` js await yield 42 in obj ```

@vietthang Here is the change we did: https://github.com/attic-labs/graphql/commit/676b0c8da5c2147c81b05a31f6cded67186cf985