Erik Arvidsson

Results 57 comments of Erik Arvidsson

Attached is a new build with asserts as well as the sourcemap for that build. [replicache-10.0.0-beta.0.tgz.zip](https://github.com/rocicorp/replicache/files/8570504/replicache-10.0.0-beta.0.tgz.zip) [replicache.mjs.map.zip](https://github.com/rocicorp/replicache/files/8570516/replicache.mjs.map.zip)

We can detect what keys a mutation touches and based on that determine if it needs to be part of the push. But that does raise a valid point that...

I don't like the array idea. I kind of like the `.local` idea but the type defs gets a bit weird: ```ts interface WriteTransaction { readonly local: Omit; ... }...

Sounds reasonable. Opting in to it for 10.x and log warnings if not opted in and key starts with the prefix and then in 11 or 12 make it default.

Needs some API design. **Pull**: We currently have: ```ts function callPuller( puller: Puller, url: string, body: PullRequest, auth: string, requestID: string, ): Promise; type PullerResult = { response?: PullResponse; httpRequestInfo:...

Looks good to me but I think we should maybe have some default implementations; `defaultHTTPPush(url)`/`defaultHTTPPull('url')`.

> On second thought we should probably wait until we integrate Reflect as that's going to affect this interface most likely. That makes sense. Let's hold off on this until...

I'm intermittently see this in tests too: ``` ▶ npm run test > [email protected] test > web-test-runner src/replicache-mutation-recovery.test.ts: ❌ successfully recovering mutations of client with same schema version and replicache...

@grgbkr said he had some ideas why there is still a possible case of this.