Erik Arvidsson

Results 57 comments of Erik Arvidsson

> Currently Replicache returns deep clones in all read interfaces for safety. This was introduced in rocicorp/replicache#479 and the rationale is there. We do not do that. `ReadTransaction` get returns...

We clone in `put` so what you put in is not going to be the same object as what you get out. I still think there is room for improvement...

Another option is to conditionally clone/freeze. React uses `process.env.NODE_ENV` as a signal for doing expensive correctness checks. We could do the same.

The current plan is to deep freeze in debug mode and do nothing in release mode (with the risk of things not working if people only test in release mode).

If we do this we should probably put the logic in `ConnectionLoop` We could also potentially only do this in debug mode.

We should also have a prefix param for the method then.

Seems too much of an edge case to spend time on this.

We can probably just have the index scans await the indexes

I would actually prefer it to be on. It looks pretty great already :-) Let me capture a screenshot and remove personal data

I redacted the conversations a bit (that is why the sidebar is all white) And collapsed sidebar