Arkadii Yakovets

Results 183 comments of Arkadii Yakovets

Hi Mauri, Thanks for the review! Yeah, you're absolutely right about how rare those special holiday occur. This PRs tends to separate all non-recurring holidays from "standard" holidays with more...

Hey Mauri, thanks for reconsidering this! I'll look into the conflicting code later today. It seems to be a piece of pre #747 PR (see [here](https://github.com/dr-prodigy/python-holidays/commit/1109bf5429cfc9bf4b771365d99c3b39957f9c14#diff-10c52acc0dc2429223e4d702594ce26668a6e7ab7cdacd875882e1876e04be31)) and it should be...

Mauri, Mike, thanks for your inputs! I understand the compatibility concern here. It makes sense to keep externally consumed results as lists for any (weird or not) use cases. I...

Hi @YusufBerki, Thank you for the PR and your work towards improving python-holidays. I have a couple of thoughts regarding the PR itself and its place in the library: -...

Hi @schmittyice-hyp! Thanks for the idea! I love this holiday! And it's quite unfortunate that at this moment python-holidays provides official holiday list (both federal and regional ones) only. I...

Hi Tim, it's always a good idea to attach the error message to a bug report and make it as detailed as possible. As there are no clear steps to...

Hey @gjohansson-ST, here is an implementation of language support option for workday sensor holidays. As it's been my first time experience with config flow please review thoroughly. I bet there...

> I don't think we should ask for the language. We should just use the local language eg German for Germany, Swedish for Sweden and so on. I'm sure that...

> @arkid15r Maybe it's better to open a new PR given there is now many people subscribed to this PR from your merge (you should rebase instead). Secondly it should...