Arkadii Yakovets
Arkadii Yakovets
The https://github.com/vacanza/python-holidays/pull/1365/ has introduced substituted holidays support recently. Please consider filing a PR to fix the issue.
Resolved in #988.
I guess this can be closed as we've reduced the runtime dependency list to a single package.
👍 👍 👍 👍 > (P.S. technically the dependencies are two, `korean-lunar-calendar` and `python-dateutil`, but the second one is widely installed.) I believe `korean-lunar-calendar` was eliminated by @KJhellico in https://github.com/dr-prodigy/python-holidays/pull/1148
Hey @jahirfiquitiva, I'm going to close this now. If it's still an issue for you please create a new ticket with detailed explanation of actual and expected behavior. Thank you
@elfring, @dr-prodigy thank you both! The issue is resolved and can be closed now.
PH supports more granular holidays definition based on region/category/special or regular status now. It should be much easier to implement those holidays support atm.
Continued in https://github.com/dr-prodigy/python-holidays/pull/887
The requested countries have been added in v0.20. Please review https://github.com/ourownstory/neural_prophet/pull/1176 Thank you for using python-holidays!
Not sure if we want to keep it open to track progress on adding those ~300 holidays mentioned by @goncaloperes and @pmpbaptista