Bo Wu
Bo Wu
> Completed audit: > > * why does a TokenData need to know its own TokenDataId as well as its name > * can we remove token_auths for mvp >...
@flappys 1. please check this shared account example https://github.com/aptos-labs/aptos-core/tree/8f7dee035f38e6a2cd508b450d656e22ca2dfb03/aptos-move/move-examples/shared_account. we support creating a shared account of multiple addresses with their own percentage. So the royalty account can be one shared...
I think it makes sense to have these API. do you mind creating a feature request specifying the APIs you want?
> I think in the ideal case, you would have the client compute the hash by pointing the SDK to the actual source of data. What are your thoughts? Yes,...
> I'd rather our SDK be opinionated here and expect to generate the hash within. generating hash within requiring 1. a file as input and 2. committed to one hash...
> I am wonder if this PR will merge into next devnet? It's a breaking change and ecosystem need time to upgrade theri contracts won't be included in the coming...
> I'm happy to land if we move this all to move-examples. I think to move forward as is, I'd think we'd probably need to review this a lot closer...
Add token_proxy to separate the experiment token modules from core token modules while retain friend relation with having significant change to product related features. This allow we iterate with new...
Hi @clay-aptos , I added a readme to this new package. Could you please review it ?
cc: @msmouse @davidiw