aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

[Token] Add auction house library

Open areshand opened this issue 2 years ago • 4 comments

Description

https://github.com/aptos-labs/aptos-core/issues/3067

Test Plan

add unit test


This change is Reviewable

areshand avatar Aug 22 '22 01:08 areshand

I am wonder if this PR will merge into next devnet? It's a breaking change and ecosystem need time to upgrade theri contracts

ericEnjoy avatar Aug 23 '22 09:08 ericEnjoy

I am wonder if this PR will merge into next devnet? It's a breaking change and ecosystem need time to upgrade theri contracts

won't be included in the coming devnet

areshand avatar Aug 24 '22 17:08 areshand

I'm happy to land if we move this all to move-examples. I think to move forward as is, I'd think we'd probably need to review this a lot closer and it would ideally be accompanied by a guide, tutorial, etc.

I'd rather land it first in move-examples and make sure it doesn't bit rot, but open to discussions.

davidiw avatar Sep 08 '22 06:09 davidiw

I'm happy to land if we move this all to move-examples. I think to move forward as is, I'd think we'd probably need to review this a lot closer and it would ideally be accompanied by a guide, tutorial, etc.

Yes, it is good suggestion. we can have more time to get more feedbacks on this work. will put them all in move example now

areshand avatar Sep 08 '22 16:09 areshand

Add token_proxy to separate the experiment token modules from core token modules while retain friend relation with having significant change to product related features. This allow we iterate with new modules while maintaining backward compatibility

When we want to deprecate existing bid/listing, we can abort the existing modules and switch the proxy to point to new modules

This is supposed to deploy to testnet for now and should only deploy to mainnet once we have confidence on the usability and security

areshand avatar Sep 15 '22 01:09 areshand

Hi @clay-aptos , I added a readme to this new package. Could you please review it ?

areshand avatar Oct 10 '22 20:10 areshand

Forge is running suite compat on 843b204dce971d98449b82624f4f684c7a18b991 ==> 000a53df5a0951ecd474ea0e28a4014a6e9db78f

github-actions[bot] avatar Oct 10 '22 22:10 github-actions[bot]

Forge is running suite land_blocking on 000a53df5a0951ecd474ea0e28a4014a6e9db78f

github-actions[bot] avatar Oct 10 '22 22:10 github-actions[bot]

:white_check_mark: Forge suite land_blocking success on 000a53df5a0951ecd474ea0e28a4014a6e9db78f

performance benchmark with full nodes : 6847 TPS, 5773 ms latency, 9100 ms p99 latency,(!) expired 2180 out of 2926260 txns
Test Ok

github-actions[bot] avatar Oct 10 '22 22:10 github-actions[bot]

:white_check_mark: Forge suite compat success on 843b204dce971d98449b82624f4f684c7a18b991 ==> 000a53df5a0951ecd474ea0e28a4014a6e9db78f

Compatibility test results for 843b204dce971d98449b82624f4f684c7a18b991 ==> 000a53df5a0951ecd474ea0e28a4014a6e9db78f (PR)
1. Check liveness of validators at old version: 843b204dce971d98449b82624f4f684c7a18b991
compatibility::simple-validator-upgrade::liveness-check : 7757 TPS, 4918 ms latency, 7000 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 000a53df5a0951ecd474ea0e28a4014a6e9db78f
compatibility::simple-validator-upgrade::single-validator-upgrade : 4481 TPS, 9279 ms latency, 13500 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 000a53df5a0951ecd474ea0e28a4014a6e9db78f
compatibility::simple-validator-upgrade::half-validator-upgrade : 4696 TPS, 9174 ms latency, 13300 ms p99 latency,no expired txns
4. upgrading second batch to new version: 000a53df5a0951ecd474ea0e28a4014a6e9db78f
compatibility::simple-validator-upgrade::rest-validator-upgrade : 7306 TPS, 5263 ms latency, 8800 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for 843b204dce971d98449b82624f4f684c7a18b991 ==> 000a53df5a0951ecd474ea0e28a4014a6e9db78f passed
Test Ok

github-actions[bot] avatar Oct 10 '22 22:10 github-actions[bot]

Forge is running suite land_blocking on 7d77996e10e56a333b32d85ac62654b5be74d9d3

github-actions[bot] avatar Oct 10 '22 22:10 github-actions[bot]

Forge is running suite compat on 843b204dce971d98449b82624f4f684c7a18b991 ==> 7d77996e10e56a333b32d85ac62654b5be74d9d3

github-actions[bot] avatar Oct 10 '22 22:10 github-actions[bot]

:white_check_mark: Forge suite compat success on 843b204dce971d98449b82624f4f684c7a18b991 ==> 7d77996e10e56a333b32d85ac62654b5be74d9d3

Compatibility test results for 843b204dce971d98449b82624f4f684c7a18b991 ==> 7d77996e10e56a333b32d85ac62654b5be74d9d3 (PR)
1. Check liveness of validators at old version: 843b204dce971d98449b82624f4f684c7a18b991
compatibility::simple-validator-upgrade::liveness-check : 7700 TPS, 4980 ms latency, 7800 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 7d77996e10e56a333b32d85ac62654b5be74d9d3
compatibility::simple-validator-upgrade::single-validator-upgrade : 4719 TPS, 8456 ms latency, 12700 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 7d77996e10e56a333b32d85ac62654b5be74d9d3
compatibility::simple-validator-upgrade::half-validator-upgrade : 4694 TPS, 8575 ms latency, 12100 ms p99 latency,no expired txns
4. upgrading second batch to new version: 7d77996e10e56a333b32d85ac62654b5be74d9d3
compatibility::simple-validator-upgrade::rest-validator-upgrade : 7482 TPS, 5189 ms latency, 8200 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for 843b204dce971d98449b82624f4f684c7a18b991 ==> 7d77996e10e56a333b32d85ac62654b5be74d9d3 passed
Test Ok

github-actions[bot] avatar Oct 10 '22 23:10 github-actions[bot]

:white_check_mark: Forge suite land_blocking success on 7d77996e10e56a333b32d85ac62654b5be74d9d3

performance benchmark with full nodes : 6899 TPS, 5782 ms latency, 9000 ms p99 latency,(!) expired 200 out of 2946320 txns
Test Ok

github-actions[bot] avatar Oct 10 '22 23:10 github-actions[bot]