Bo Wu comments

Results 38 comments of


                                            Bo Wu

[Feature Request] Make stored transaction error not used for hash calculation

> @areshand - Can you clarify which schema in DB you are referring to? Is it the execution status stored in `TransctionInfo` https://github.com/aptos-labs/aptos-core/blob/main/types/src/transaction/mod.rs#L1014 ? Yes, it is the execution status.

[Feature Request] Make stored transaction error not used for hash calculation

> eral and used for user query purpose only. > According to error code change, I believe it is also a breaking change to move vm so even we don't...

[Feature Request] Make stored transaction error not used for hash calculation

As recommended by @sitalkedia an alternative is _simply defining a custom hash function for TxnInfo should do I believe. I am not sure introducing a new CF for execution status...

[Feature Request] Make stored transaction error not used for hash calculation

@msmouse 's take _K. My take: 1. a lean / stable version of the error code (the same thing before the change) is part of the TxnInfo, not the more...

[Bug]Creating a new account with 0x1::aptos_account::create_account

Yes, the document is outdated. we already migrated to 32 byte address.

[aptos-token] Add OwnerStore to support get latest owner of token id

> Does anyone have a review ? if I'm wrong please point it out. I only changed the move code, the code inside aptos-core is a bit difficult for me,...

[aptos-token] Add OwnerStore to support get latest owner of token id

> ship can be notified to the off-chain system through event. But it cannot handle the scenario of calling between contracts on the chain. > > Such as the `Domain...

[Aptos Framework][Account] added rotation capability offer and revoke functions

1. I don't see any function using `RotationCapability` to rotate the auth key. we should add these delegation&revoking after the capability is used somewhere. 2. another issue is rotation capability...

[Token] Add update collection data method(after resolve conflict)

@chloeqjz @movekevin @davidiw please take a look

Error on Mint NFT move file on example

@ozgur3512 0x10002 means key doesn't exist [[code](https://github.com/aptos-labs/aptos-core/blob/21991ffa96acde5ec211ba73dea42528a29b1e01/aptos-move/framework/aptos-stdlib/sources/simple_map.move#L16)]. The first 1 is the error category and the 2 is the hex encoding of the constant error code in source file. I...