arcady-lunarg

The other change has been merged now.

Looks like more line ending problems, ugh.

Looks like the failures are line ending issues, make sure you're adding both the test file and the result file with line endings that are consistent between the two of...

@qingyuanzNV I think you need to move the test back to the runtests script, it is there because it gets run twice with different command line options, for one thing...

FYI, this is what the GLSL spec has to say about integer overflow in section 4.1.3: > Addition, subtraction and multiplication resulting in overflow or underflow will result in the...

The CI test failures should also be a clue, I think your truncation isn't working correctly.

It's a bit of a minefield getting everything to work right in all situations including MinGW and proper integration with what package builders use, so any change should be tested...

I think the concern about spurious diffs is a valid one, and it's been an issue for me as well when trying to review changes that add or remove some...

This is technically a glslang error I think, SPIR-V 1.0 does indeed have the restriction you mention and so glslang should not be generating this code because you explicitly requested...

I think you need to see whether the changes caused to the tests are reasonable and if so, update them. Are you sure your code is correct though? It seems...