glslang icon indicating copy to clipboard operation
glslang copied to clipboard

Improve gtest infra and add include file test

Open qingyuanzNV opened this issue 5 months ago • 8 comments

  • Add includer to gtest for include file tests.
  • Move some tests from legacy script to gtest.
  • Turn on debug info flag for non-semantic debug test.

This is the infra part of change from https://github.com/KhronosGroup/glslang/pull/3513

qingyuanzNV avatar Mar 01 '24 21:03 qingyuanzNV

Part of this is addressed by #3375 which I am going to actually merge shortly because I finally figured out the line endings issue, so you're going to have to rebase this, but you also should have fewer CI problems.

arcady-lunarg avatar Mar 01 '24 22:03 arcady-lunarg

Okay. I'll rebase after that one is merged.

qingyuanzNV avatar Mar 01 '24 22:03 qingyuanzNV

The other change has been merged now.

arcady-lunarg avatar Mar 01 '24 23:03 arcady-lunarg

Looks like more line ending problems, ugh.

arcady-lunarg avatar Mar 15 '24 00:03 arcady-lunarg

Looks like the failures are line ending issues, make sure you're adding both the test file and the result file with line endings that are consistent between the two of them, I think probably unix line endings would work better in this case.

arcady-lunarg avatar Mar 20 '24 23:03 arcady-lunarg

Yeah, I guessed the same. I'm quite busy with some other deadline recently and I'll get back to this tomorrow.

qingyuanzNV avatar Mar 20 '24 23:03 qingyuanzNV

@arcady-lunarg sorry to get back to this late. I have addressed the line-ending issue for all test files. Please help review and squash with the following commit message.

Improve gtest infra for includer support and add include file test
- Add includer to gtest for include file tests.
- Move some tests from legacy script to gtest.

qingyuanzNV avatar Apr 11 '24 21:04 qingyuanzNV

@qingyuanzNV I think you need to move the test back to the runtests script, it is there because it gets run twice with different command line options, for one thing one version is run with -G and the other with -V.

arcady-lunarg avatar Apr 12 '24 15:04 arcady-lunarg