Julian Tölle

Results 299 comments of Julian Tölle

> Renovate seem to struggle because it is trying to update the devcontainers files: https://github.com/hetznercloud/cli/blob/main/.devcontainer/Dockerfile > > I'd be in favor of removing the dev container files altogether. I am...

Hey @jnovermars, I can not reproduce the issue on the latest version or on `main`. I do use Linux though. You are running your gitlab-ci pipeline on macOS? What is...

Hello @mzhaase, in my opinion this is not the responsibility of the csi-driver. In an ideal world you could wrap the csi-driver in some way, where we only handle the...

Hello @tehnic-take3, ### FQDN Server Names where do you use the FQDN server names? By default hcloud-cloud-controller-manager requires that the name of the Kubernetes `Node` matches the name of the...

In e2e tests this reduced the time of the `skaffold run` step from ~1m50s to ~1m30s (-18%).

Hey @elohmeier, thanks for the PR! Our team is a little bit short on time right now with vacations, so the review is going to take some more weeks. I...

I am also against this, but for another reason. If we always run `go mod tidy` we force all dependents to upgrade their dependencies as well, to the versions we...

> Happy to leave this until https://github.com/kubernetes/enhancements/issues/1860 is in GA :) As long as the API does not error when the field is present I think we can merge. AFAICT...

We could also check the server version and only add the field on 1.29+: https://pkg.go.dev/k8s.io/[email protected]/discovery#ServerVersionInterface

I did not yet, and unfortunately our GitHub Actions test suite does not work for PRs from forks :(