hcloud-cloud-controller-manager icon indicating copy to clipboard operation
hcloud-cloud-controller-manager copied to clipboard

chore(dev): speed up image build with ko

Open apricote opened this issue 1 year ago • 4 comments

Ko builds the binary locally and utilizes the local go build cache.

This makes the deployment with skaffold faster locally and in our e2e tests.

This makes the dev setup more different than the production setup (still using Dockerfile). But they were already a bit different anyway. In the mid-term I want to use ko for the production images too.

apricote avatar Jul 08 '24 10:07 apricote

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.26%. Comparing base (2ba4058) to head (a53af30). Report is 126 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #692      +/-   ##
==========================================
+ Coverage   72.16%   72.26%   +0.09%     
==========================================
  Files          31       32       +1     
  Lines        2497     2668     +171     
==========================================
+ Hits         1802     1928     +126     
- Misses        523      552      +29     
- Partials      172      188      +16     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 08 '24 10:07 codecov[bot]

In e2e tests this reduced the time of the skaffold run step from ~1m50s to ~1m30s (-18%).

apricote avatar Jul 08 '24 10:07 apricote

This PR has been marked as stale because it has not had recent activity. The bot will close the PR if no further action occurs.

github-actions[bot] avatar Oct 06 '24 12:10 github-actions[bot]

This PR has been marked as stale because it has not had recent activity. The bot will close the PR if no further action occurs.

github-actions[bot] avatar Feb 13 '25 12:02 github-actions[bot]