Julian Tölle
Julian Tölle
Some steps: 1. Add new field `PlacementGroup string` to struct `NodeConfig` in `hetzner_manager.go` 2. Add new field `PlacementGroup *hcloud.PlacementGroup` to struct `hetznerNodeGroup` in `hetzner_node_group.go` 4. In `hetzner_cloud_provider.go` `BuildHetzner` in line...
~~That should indeed be `http-redirect-https`. Though changing this now would be a breaking change. Perhaps best to add the correct option besides and use that if its set and fall...
After looking at it again, I understand why `http-redirect-http` was chosen in the first place. The API schema for this is `{ "http": {"redirect-http": true }}`, so the annotation was...
One of the files is not properly formatted, that causes the CI failure in `test-and-verify`. You can fix it by following the CI output: > Please run hack/update-gofmt.sh to fix...
/approve Thank you very much @dominic-p!
Hey @DeprecatedLuke, I am unable to reproduce the issue locally with your reproduction steps. Could you run hcloud-cloud-controller-manager with the environment variable `HCLOUD_DEBUG=true`? This will log all requests made to...
Thanks for the PR @a-mader, this is indeed a breaking change, so I will not merge it as is. I wrote a bit about the origin of the current annotation...
I would prefer to not mark `LBSvcRedirectHTTP` as deprecated. After all it is the one matching the API.
Can you explain where you need this for? I would really prefer if this was implemented in `k8s.io/cloud-provider` for all cloud providers to use and not downstream in every single...