hcloud-cloud-controller-manager icon indicating copy to clipboard operation
hcloud-cloud-controller-manager copied to clipboard

Implement support for custom internal IP mapping via HCLOUD_INSTANCES…

Open elohmeier opened this issue 1 year ago • 3 comments

This update adds the ability to specify custom internal IP addresses for Hetzner Cloud and Robot Instances through the HCLOUD_INSTANCES_INTERNAL_IP_MAP environment variable.

This is especially useful when mixing cloud servers with dedicated robot servers via vSwitch / private networks. Users will need to manage the IPs of the robot servers manually anyway, this change let users specify them as well for the InternalIp field in K8S.

elohmeier avatar Jul 09 '24 15:07 elohmeier

Hey @elohmeier, thanks for the PR! Our team is a little bit short on time right now with vacations, so the review is going to take some more weeks. I am sorry for this.

apricote avatar Jul 22 '24 13:07 apricote

Thanks for you message, no problem. I wonder if there is upstream interest for this addition? If so, please let me know - I would then take a look into the CI issues and rebase.

elohmeier avatar Jul 22 '24 15:07 elohmeier

This PR has been marked as stale because it has not had recent activity. The bot will close the PR if no further action occurs.

github-actions[bot] avatar Oct 21 '24 12:10 github-actions[bot]

Rebased onto latest main branch.

elohmeier avatar Oct 29 '24 14:10 elohmeier

@elohmeier Can you add a usage example for how to specify the mapping? Tried your PR but neither got the IP added nor an error in hccm. Specified it as

          HCLOUD_INSTANCES_INTERNAL_IP_MAP:
            nodename: 'nodeip'

pat-s avatar Nov 11 '24 07:11 pat-s

would highly appreciate and looking forward for this PR to be merged

mehrdadpfg avatar Dec 04 '24 13:12 mehrdadpfg

can we bump this one in order to be able to set internal ip for robot servers? @pat-s the map should be comma seperated

HCLOUD_INSTANCES_INTERNAL_IP_MAP: node-1=1.1.1.1, node-2=2.2.2.2

the name should match the robot name

mehrdadpfg avatar Jan 16 '25 14:01 mehrdadpfg

Hey,

apologies for the recent lack of activity. I will bring this topic to our discusssion next week.

Best Regards, Lukas

lukasmetzner avatar Jan 16 '25 15:01 lukasmetzner

Hey,

after reviewing open tickets and PRs we have decided on a solution that we want to implement. @elohmeier Thank you nonetheless for your contribution ^^

Best Regards, Lukas

lukasmetzner avatar Feb 04 '25 09:02 lukasmetzner

Hey,

as already mentioned we now implemented the solution from @codablock. In our new release v1.24.0 it is now possible to configure an InternalIP for a Robot node via the kubelet flag --node-ip.

Thank you for your contribution ^^

I will go ahead and close this PR now.

Best Regards Lukas

lukasmetzner avatar Apr 16 '25 08:04 lukasmetzner