Andrew Peabody

fix: change asm module depends_on method

2

* Workaround for https://github.com/terraform-google-modules/terraform-google-gcloud/issues/123

feat: add module_depends_on to workload-identity

5

Per https://github.com/terraform-google-modules/terraform-google-gcloud/issues/82

chore: move network to node_pool examples

1

Fixes #1222

Possible flaky CI with remove_default_node_pool = true

4

### TL;DR Possible flaky CI with `remove_default_node_pool = true` ``` Error: Error deleting default node pool: googleapi: Error 400: Operation operation-{} is currently creating a node pool for cluster node-pool-cluster-{}....

Update examples/node_pool to include definition of the network ranges

4

### TL;DR Update examples/node_pool to include definition of the network ranges. For example move https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/77d08e02d738c38a5c68987572ef506a987dd41e/test/fixtures/node_pool/network.tf#L49 to https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/tree/77d08e02d738c38a5c68987572ef506a987dd41e/examples/node_pool ### Expected behavior _No response_ ### Observed behavior _No response_ ### Terraform Configuration...

feat: new random_project_id_string_method

1

* New `random_project_id_string_method` with larger collusion domain from [0-9a-f]4 to [0-9a-z]4, and adjustable length.

modules/mig replacement_method should default to SUBSTITUTE

3

### TL;DR modules/mig replacement_method should default to SUBSTITUTE https://cloud.google.com/compute/docs/instance-groups/rolling-out-updates-to-managed-instance-groups#replacement_method ### Terraform Resources _No response_ ### Detailed design _No response_ ### Additional information _No response_

feat: [anthos-bm-gcp-terraform] Updates to init_args trigger instance rebuild

3

It might be nice to have updates to [init_args ](https://github.com/GoogleCloudPlatform/anthos-samples/blob/945adb00ff153d114ddef4a6f73591d9b485152b/anthos-bm-gcp-terraform/main.tf#L280) trigger a rebuild of the instances to keep the state consistent.

To prevent conflicts with repeated usage, a randomized suffix could be automatically attached to the cluster name/resources. Would also workaround #261

In TF 0.13+ all list elements must have the same type

1

### TL;DR Historically `list(any)` was used for https://github.com/terraform-google-modules/terraform-google-gcloud/blob/6789fa726f443e36a3159f452eec0fc5f9a9ff4b/variables.tf#L35 However subsequent to https://github.com/hashicorp/terraform/issues/26265, all list elements must have the same type. So for example this fails: `module_depends_on = [time_sleep.wait_300_seconds, null_resource.test]` The...