terraform-google-kubernetes-engine icon indicating copy to clipboard operation
terraform-google-kubernetes-engine copied to clipboard

Update examples/node_pool to include definition of the network ranges

Open apeabody opened this issue 3 years ago • 4 comments

TL;DR

Update examples/node_pool to include definition of the network ranges. For example move

https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/77d08e02d738c38a5c68987572ef506a987dd41e/test/fixtures/node_pool/network.tf#L49

to

https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/tree/77d08e02d738c38a5c68987572ef506a987dd41e/examples/node_pool

Expected behavior

No response

Observed behavior

No response

Terraform Configuration

N/A

Terraform Version

N/A

Additional information

No response

apeabody avatar Apr 13 '22 19:04 apeabody

@apeabody We really want to reduce the use of variables over-time, actually. Ideally most examples should be self-contained and liberally include static values instead of variables.

morgante avatar Apr 13 '22 19:04 morgante

@morgante Agreed, this issue is the example isn't totally self-contained as that network range is defined in the test fixture. Thought?

apeabody avatar Apr 13 '22 19:04 apeabody

The ideal fix would be moving the network creation from the fixture to the example. Eventually we want to get rid of fixtures entirely.

morgante avatar Apr 13 '22 19:04 morgante

SG - I updated the issue to align.

apeabody avatar Apr 13 '22 19:04 apeabody