terraform-google-kubernetes-engine icon indicating copy to clipboard operation
terraform-google-kubernetes-engine copied to clipboard

Published 20 hours ago • verified publisher icon terraform-google-modules

feat: add module_depends_on to workload-identity

Open apeabody opened this issue 3 years ago • 5 comments

Per https://github.com/terraform-google-modules/terraform-google-gcloud/issues/82

apeabody avatar Aug 01 '22 23:08 apeabody

Requires #1342

apeabody avatar Aug 02 '22 20:08 apeabody

Also @apeabody I believe https://github.com/terraform-google-modules/terraform-google-gcloud/issues/82 is for supporting the native depends_on for gcloud which wont be fixed by this.

bharathkkb avatar Aug 03 '22 03:08 bharathkkb

Also @apeabody I believe terraform-google-modules/terraform-google-gcloud#82 is for supporting the native depends_on for gcloud which wont be fixed by this.

Thanks @bharathkkb - Yes, this and https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/pull/1323 were for an add-on later in the thread https://github.com/terraform-google-modules/terraform-google-gcloud/issues/82#issuecomment-1200470533. I'll change the PR comment to leave the overall issue open.

apeabody avatar Aug 03 '22 15:08 apeabody

Holding for discussion on https://github.com/terraform-google-modules/terraform-google-gcloud/issues/123

apeabody avatar Aug 05 '22 18:08 apeabody

Enhanced docs per https://github.com/terraform-google-modules/terraform-google-gcloud/issues/123

apeabody avatar Aug 17 '22 21:08 apeabody

@apeabody Thanks for the PR! 🚀
✅ Lint checks have passed.

comment-bot-dev avatar Aug 17 '22 21:08 comment-bot-dev