Andor Molnár

Results 120 comments of Andor Molnár

@PeterShaggyNoble @hard-working-boy As a ZooKeeper PMC, I'd like +1 this request. Is it not possible to store color icons in this repo? If not, maybe you could try filling the...

Thanks @taklwu , I've updated the minimum configuration in the description with more details. Sorry for the confusion, I've decided to abandon the feature branch to speed up the rebasing...

> lgtm. > > Has it been upgraded on the master branch yet? No, because we use `logback` on master/3.8. Sorry ignore my comment. Though you don't need to create...

I always support adding documentation, but fyi RequestProcessors are very well documented in the book.

@maoling Sure. Please let me know if you're done.

It doesn't seem to be a big deal to me, but happy to commit if you could create a Jira for it.

> And moreover changing variables names can make life harder while porting patches from other branches. That's a valid concern.

@lvfangmin This patch has been abandoned unfortunately, but the issue should be fixed one way or the other. Would you please take another look? I'm happy to commit as it...