zookeeper icon indicating copy to clipboard operation
zookeeper copied to clipboard
verified publisher icon apache

making some variables in the FastLeaderElection.java conform to the Camel-Case naming standard

Open cyxpdc opened this issue 6 years ago • 6 comments

I'm sorry, but I'd like to change the names of these two variables to make them more comfortable.

cyxpdc avatar Oct 14 '19 07:10 cyxpdc

and logicalclock，maybe “logicalClock”?

cyxpdc avatar Oct 14 '19 09:10 cyxpdc

@cyxpdc

  • Create a JIRA ticket for this.The contributor guideline is [here] (https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute])
  • Give this PR a better name? e.g: making some variables in the FastLeaderElection.java conform to the Camel-Case naming standard

maoling avatar Oct 14 '19 09:10 maoling

@cyxpdc

  • lots of annotations in this class mention this outofelection, you can use IDE tool to rename all of them
  • Do you have an chance to find all the naming issues in this class:FastLeaderElection to make this patch bigger :)?

maoling avatar Oct 21 '19 02:10 maoling

@maoling

  • A lot. I'm a little busy recently.,maybe I have time later.I'm sorry.

cyxpdc avatar Oct 21 '19 06:10 cyxpdc

It doesn't seem to be a big deal to me, but happy to commit if you could create a Jira for it.

anmolnar avatar Nov 22 '19 19:11 anmolnar

And moreover changing variables names can make life harder while porting patches from other branches.

That's a valid concern.

anmolnar avatar Dec 11 '19 17:12 anmolnar