Andor Molnár
Andor Molnár
Ooops, I was too quick. There's no jira ticket for this patch, but it might be okay given this is a contrib only change.
@Kota-SH @kgeisz Are the unit test failures related? Can we move on with merging this PR?
> 3. If we have normal replication enabled (a normal replication peer), will all CFs with REPLICATION_SCOPE = 1 also be targeted for this PITR? Negative. Continuous backup needs a...
> 5. Should the pitr endpoint replicate method consider if the underlying FS supports sync before deciding the result to return? The PITR endpoint assumes that `sync()` is not supported...
> 6. Does it support pause (disable_peer)? This is a very good question. Given that it's a standard replication endpoint, I would say sure, why not. This is something that...
> 7\. Can we include doc changes within this PR? I suggest to finish reviewing and merging this patch first. Proper documentation and integration testing should come afterwards in separate...
> LGTM, all my questions have been addressed. > > Regarding the wal tracking approach, I don't have a strong opinion. @Apache9 , do you think this is a blocker...
> Mind taking a look at [HBASE-28521](https://issues.apache.org/jira/browse/HBASE-28521)? In general, we want to avoid leaking the internal zookeeper, so for replication, we want to use the standard connection registry API to...
Yep, just checked it and that's exactly what @Apache9 's patch addresses. I suggest submitting #5825 and #5835 first, then rebase this patch and we'll be fine.
> #5825 is not necessary for solving the problem for this PR, #5835 is enough, as after #5835, we are able to customize the ZKClientConfig through the Configuration map in...