Andor Molnár
Andor Molnár
Are you sure that we don't need to synchronize between snapshotting and `sync()`?
@kezhuw Thoughts?
> We ran into perf issue when had sync on the ZookeeperServer object. Whenever snapshot was taken, the sync operations were queued up in the outstanding request queue and the...
> LGTM > > > it causes lock contention on the ZookeeperServer object with the sync operation. > > Does anyone have any cue about why `sync` get `synchronized` ?...
[ZOOKEEPER-136](https://issues.apache.org/jira/browse/ZOOKEEPER-136) added synchronized to sync()
@kezhuw This one if waiting for 3.9.3 release. Please help in review.
@kezhuw @eolivelli @li4wang @ztzg I've just come across this one and started to review for 3.9.3, but need more eyeballs. Could you please review?
@zichen-gan You need to close / re-open PR or force push to trigger another CI run.
> Given above, I think it is promising. It promotes rollover rate from `49.7` days to `34.9` years assuming `1k/s` ops. The best is that it demands no protocol change...
You might want to rebase the patch to re-trigger the failing tests.