Andy Waite
Andy Waite
> Therefore, I wonder if we should just mark the cop as an unsafe autocorrection and make assumptions in the correction code. This seems reasonable to me. For any non-trivial...
Yep. Perhaps there needs to be an `ORM` configuration option.
Perhaps also worth an entry in https://github.com/rubocop-hq/rails-style-guide
The only way I can think of that would be unsafe is if someone had accidentally defined the same method twice in a controller, so that only the later one...
> Heh yeah, so it comes down to the significance of -A vs. -a I guess -a should never ever have any opportunity to go wrong, so we have to...
(normally `Lint/DuplicateMethods` would catch this, but that cop might be disabled).
I'd suggest aiming for a first release without safe-correction, and then safe-correction can be addressed in a follow-up.
I think it's still useful to have timestamps on a join table, even if just for troubleshooting.
Just for reference, here's the original PR: https://github.com/rubocop-hq/rubocop/pull/3415
I suspect very few people want to maintain separate HTML and text versions of emails in 2022.