Andy Waite
Andy Waite
Worth mentioning the `on_potential_false_positives` config option? https://www.andywaite.com/2018/07/15/prevent-false-positives-rspec-error.html
Since this isn't specific to Ruby code, I don't think it belongs in RuboCop. I'm sure other solutions will emerge soon, e.g. as a GitHub Action.
Thanks for implementing this @r7kamura!
I agree that file should always be named `some_xml.rb`, but I think it could be worth covering whether the class name would be `SomeXML` or `SomeXml`. My impression is the...
(maybe it's not so clear-cut in JS - [XMLHttpRequest](https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest) has two style in the one name!)
I feel this is more general style choice of whether method calls should use parentheses or not. Perhaps it would be better to be have this in RuboCop itself?
Nice idea about parsing for conjunctions but i think that may be difficult to get right. I didn't consider whether it's inside of a `context` or not – perhaps this...
Great work! A first thought: `ActiveSupport::Testing::TimeHelpers` isn't available be default, (at least not in rspec-rails anyway), so the autocorrect would could break some tests. It's probably not reasonable for the...
Perhaps it could include a link to a page with more details? (I'm not sure if any other cops do anything like that).
+1 for having this within rubocop-rails. It's one of a very small number of gems that are so embedded within the ecosystem that it led to Rails adding a feature...