Andrew Godwin

Results 206 comments of Andrew Godwin

Ugh, yeah, this is tricky because end-users mypy installations is the thing we care about at the end of the day. No way to somehow erase ParamSpec and fall back...

Maybe? I don't keep tight track of typing stuff right now so I'm not quite sure where things sit in terms of this working with 3.7.

Yeah, I'm going to remove that from the documentation for now as it doesn't work yet. We should, however, add support for it in.

I opened a PR to remove the doc example here: https://github.com/django/django/pull/12706

It wouldn't be good form to mix it up with a pull request for a different thing - happy to accept a separate PR for that, though.

I'm guessing that the `pytest.mark.django_db` decorator from `pytest-django` is probably interacting with Channels here. What happens if you remove that?

Hm. Then yes, this is a bad interaction between pytest-django and Channels, as they both do thing to try and make the ORM function properly outside of a request. Try...

Hm, this is going to need some more investigation by someone to figure out if we can make the two cooperate. For now I'd recommend trying to avoid these kinds...

Looks like this got duped into #1234, but I think I may have fixed it in the most recent commit. Testing of that would be welcome.

Oh, right, that old biscuit. Then I guess we'll have to leave this open.