Andrew Godwin

Results 206 comments of Andrew Godwin

Oh, it's specifically DRF? Hm. Does it work if you do it via a normal Django view?

This is likely a bug in Channels, actually - there's not any POST body tests right now and I don't manually check it very often. I'll take a look at...

That looks about right to me - does the test pass?

It may be a problem in Daphne rather than Channels, then, as that's the thing not being tested. I'll be able to get to looking at that by the weekend...

I do agree something needs to happen here - it's important to have explicit failure - but not a huge fan of the `acknowledge` event model, that just seems a...

So the specific behaviour you would want to change is that the ASGI server swallows any exceptions during startup: > If an exception is raised when calling the application callable...

Lock is not acquired errors are likely happening because you hit the application close timeout and are being force-killed. I'd look into why the app isn't closing.

Well, group membership takes a day to expire by default, but the `discard` handler should be removing these (unless something is locking up your application on disconnect, which it sounds...

I can't see anything obvious there - even if you had an exception that raised and skipped over the StopConsumer it would still halt the coroutine and log to console....

Ah, curious, calling async inside sync inside async. That would make me a little suspicious.