Andrew Nesbitt
Andrew Nesbitt
If that's the case, we'll need to pass the notification type to the `SubjectUrlParser` as well to get this working.
Seems related to #400, often the notifications API doesn't point to the review being the latest comment, or if the review includes a comment then the notifications API doesn't know...
Sounds like a bug, I've not heard of anyone using the restrict access feature whilst running octobox as a github app before (i've not done it myself either)
@timebertt yeah I think it's a valid use case, just not once that I've personally tried.
Not exactly what you've proposed but I am working on a browser extension to integrate Octobox directly into GitHub: https://github.com/octobox/extension
I'd love for this functionality too but I don't believe github provide any kind of api to access or update "done" in their notifications, might be worth contacting them to...
Yep this would be a great feature! Here's a helpful stackoverflow thread on detecting the users preference in css and js: https://stackoverflow.com/questions/50840168/how-to-detect-if-the-os-is-in-dark-mode-in-browsers
I don't think this makes sense to have in Octobox at the moment, the GitHub API makes it really slow to unsubscribe from multiple things and we don't really have...
Agreed, I think it makes sense to add this into Octobox now so reopened 👍
![Screenshot 2021-03-31 at 19 00 33](https://user-images.githubusercontent.com/1060/113189763-76eb3900-9253-11eb-8ef1-3dad0fffe609.png) I believe that you can get to the original issue/pr by pressing the "open" status icon, it's definitely not the most obvious link and...