anand1976

@jsteemann Sorry for the delay! I'll get back to you early next week.

The error recovery behavior when 2pc is enabled seems overly restrictive - https://github.com/facebook/rocksdb/blob/main/db/error_handler.cc#L513. For the short-term, we could relax it so certain types of errors, such as errors when writing...

@ytrezq Can you share the exact commands used to create the DB and then compact it?

@kriti-sc That sounds great! Thanks for volunteering. Let me know what you have in mind. I'll be happy to discuss and help out in any way.

Thanks for your interest. I think long term a secondary cache based on persistent memory would be interesting. The hardware is not widely available or used yet, so it's still...

@chenyou-intel Thanks for the contribution! I'll take a look in the next week or so.

> > Before this PR, the variable `value` still keeps data in memory when `create_cb()` fails and `cache_->Release()` is called. `value` is a `void*` and not a `unique_ptr`, so setting...

> What version of gcc does folly require? I use Ubuntu 20.04 and 22.04 -- both are LTS (long term supported) but 22.04 has yet to be fully released. With...

@narayana1923 It may not necessarily be a problem with the functions shown on the stack. Some memory corruption could have occurred earlier. Can you reproduce this with an asan build?

> > How does the user specify the callback? In `WriteOptions` perhaps? > > Yeah, that's a good question. `WriteOptions` would work, another idea is maybe we can make `WriteWithCallback`...