rocksdb icon indicating copy to clipboard operation
rocksdb copied to clipboard

Published 20 hours ago • verified publisher icon facebook

Prototype invoking a post wal write callback in pipelined write mode

Open jowlyzhang opened this issue 9 months ago • 3 comments

This is a prototype PR. Although it's not planned to be checked in, it would be good to have some reviewing feedback before we send it to Hammerspace for integration and testing.

jowlyzhang avatar May 01 '24 23:05 jowlyzhang

How does the user specify the callback? In WriteOptions perhaps?

Yeah, that's a good question. WriteOptions would work, another idea is maybe we can make WriteWithCallback a public API too?

jowlyzhang avatar May 02 '24 17:05 jowlyzhang

How does the user specify the callback? In WriteOptions perhaps?

Yeah, that's a good question. WriteOptions would work, another idea is maybe we can make WriteWithCallback a public API too?

Yeah, WriteWithCallback should be fine too. We should have an overload that doesn't take WriteCallback as that seems specific to transaction DB, and maybe name PostWalWriteCallback to something more generic.

anand1976 avatar May 02 '24 18:05 anand1976

LGTM! Thanks for the PR and quick turnaround

Thank you for the quick review!

jowlyzhang avatar May 02 '24 22:05 jowlyzhang

@jowlyzhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jun 01 '24 00:06 facebook-github-bot

@jowlyzhang merged this pull request in facebook/rocksdb@fc59d8f9c6a8d8b4ff506708f1e78d3b3b54686b.

facebook-github-bot avatar Jun 01 '24 02:06 facebook-github-bot