Łukasz Langa
Łukasz Langa
How much does it slow Bitrot down?
I don't understand how the current behavior (which sets encoding to 'utf8' in the NamedTemporaryFile) is any worse than your suggested encoding of every line to utf8 and writing in...
Good call! Could you make a pull request to that effect? I'll happily accept it.
Set "maxDiff = None" in the test case class to see the full diff. I cannot repro, what mypy version is that with?
I cannot reproduce your issue. Are you saying that passing a custom mypy.ini in .flake8, setup.cfg, or on the flake8 command-line doesn't work? It certainly does for me.
I like the idea in general. The comments on the original pyflakes issue are fair though: if you are implementing a new function that needs to conform to some known...
That would be neat, indeed. Sadly, it's not trivial since our AST doesn't include this information.
I'm only worried about the additional overhead for just this one check. lib2to3 is in Python so it's going to slow down Bugbear a bit. We can do it and...
If you use http://github.com/ambv/black/, it will helpfully wrap one-tuples in parentheses to make this more obvious. So if this wasn't intentional, it will be easier to spot.
This is a very interesting find! Looks like we might not be visiting certain paths through the tree. If you could create a minimal example with this, that'd be helpful...