Łukasz Langa comments

Results 194 comments of


                                            Łukasz Langa

Cython grammar support

Hi, @pablogsal.

Pipenv fail installation - Add documentation

Praveen, it's hard to help you without you specifying versions of all things. I suspect you're trying to install Black with Python 2.

Docstrings should be forced to use triple quotes

This is indeed what [PEP 257](https://www.python.org/dev/peps/pep-0257/) is suggesting. My only concern is what happens if this pushes the docstring over the line (e.g. makes it too long). In any case,...

Is --target-version the minimum or should all be explicitly listed?

Jelle, I get that certain edge cases in the grammar are only available in the newer versions, so we need the lower bound. Why do we need the upper bound,...

Is --target-version the minimum or should all be explicitly listed?

At the same time I agree that it should almost certainly be 3.6+, 3.7+, 3.8+, and so on. But Jelle's got a point about possible syntax breaking changes in the...

Only enforce blank line separation between functions and classes at the same level of nesting

I'm not convinced. > The same applies to classes, like, how does this blank line help anything? Well, I remember a certain gentleman fight really hard back when Black was...

Only enforce blank line separation between functions and classes at the same level of nesting

(Similarly to #449, I want the rule that we'll implement to be trivially explicable to beginners.) ### Opening blank line vs. closing blank line I think it's uncontroversial to say...

Only enforce blank line separation between functions and classes at the same level of nesting

A full example of current behavior which we'd like to standardize: * [show on Black Playground](https://black.now.sh/?version=master&state=_Td6WFoAAATm1rRGAgAhARYAAAB0L-Wj4AaaAT9dAD2IimZxl1N_Wg0-BAh87OhF_waaeL_SgnUWBNEwRsEnrrPZrMVU6bJgKm9EEoff22XOQan5rG6n-zcy6ZaxCIGZhMmsydLE-5bvqIKOeEzGjCMF-zXAyQgcEQOfFWRvK-igiynnJu97aZUkIS-VW5od0eg7GAiF6ZzkjhySBdr2DKJebgmjcmvBKPF1KJSBdixmnfMT5WOZ1LC_eDcmiUr32YyCpd_T5n_iGNlxMyk3qBWvDx0W1YcR5yziFnMLUJUupNODBk1nF84hAq_TVyF-nHhtSUIOYIT7hZBjHrogHx0rcZA5Ap_IaCqOTyj15Wk8tlNwOqYoQf8qLQ-Zyw0gEP9pjdhI1_zgl5WaL_2G_6ztA5pIzTQrWko1GYIzSBTJl4ncBCRrtARB2FcQzjP6-S1ETabZ2FeziKwyYSAAAC00jE4hYbumAAHbApsNAACnnvWjscRn-wIAAAAABFla) To be clear, the example above does not demonstrate the behavior we'd like, only...

Option to apply on an indented fragment of Python code (e.g. a single method)

Due to https://github.com/microsoft/vscode-black-formatter/issues/176 we should tackle this soonish.

Use parentheses in: a = b == c

This is one of those "eye of the beholder" cases. For each careful Nathaniel pair of readability parens, there's going to be plenty of unnecessary ones put by less experienced...