flake8-mypy icon indicating copy to clipboard operation
flake8-mypy copied to clipboard

Add support for comments containing Unicode

Open DevynCJohnson opened this issue 7 years ago • 1 comments

When using Flake8 (with Flake8-Mypy) on Python scripts containing comments with Unicode comments, Flake8 crashes with a UnicodeEncodeError. The suggested code in my commit appears to resolve the issue without side-effects.

DevynCJohnson avatar May 19 '18 22:05 DevynCJohnson

I don't understand how the current behavior (which sets encoding to 'utf8' in the NamedTemporaryFile) is any worse than your suggested encoding of every line to utf8 and writing in binary.

ambv avatar May 20 '18 18:05 ambv