Łukasz Langa
Łukasz Langa
You're right that there's too little time for an overhaul now. Let's table this, I gave smaller scale suggestions back in #495.
This PR is stale, closing.
I think the proposed approach is wrong. You can't use the existing understanding of strings and separately decompose them. You don't know the endquote up front anymore because this is...
No, the call stack isn't automatically compatible with the stack we need here. You need to change how `endprog` in `generate_tokens` works for strings. This is where the new stack...
Good point that we should do backslash normalization here as well for 3.12+ source code input. Sounds like a non-trivial design surface so it wouldn't be an issue if we...
AFK right now but I'll do a review tomorrow. Thanks for working on this!
Yeah, the problem is exactly that you upgraded sqlglot over several versions.
This is funny to even mention but since Black works on Python 3.7+, it will run on Windows 7, ~~8~~, 8.1, 10, and 11. ~~Maybe even Vista 😂~~ Python 3.9...
How about instead we just put those lines in a `if TYPE_CHECKING:` block?
Then we can keep 3.8 compatibility.