Alexandre Quercia
Alexandre Quercia
- To be consistent with sequence types the `2a` should be the best option. - Multi-lines sequence types declaration should be look like that IMHO: ``` python # list foo...
PHP does not support the double serialization, very weird. ```php
## Behaviours #### The actual working behaviour ```shell cd path/to/symfony-project-root ./symfony --version ``` #### But, that does not work ```shell cd path/outside path/to/symfony-project-root/symfony --version ``` ## Possible solution ### 1....
> It looks like this PR was never merged. @alquerci does this just need a PHP-7.3-specific test in sfWebResponseTest.php? @mkopinsky yes The idea is the following: Write the test that...
@thePanz I think that make sf1 compatible with latest PHP version is another topic than removing support for old PHP versions. What problem will be fixed by removing all PHP...
@thirsch rebased. And build test passes without cache. ``` docker-compose build --no-cache ```
@thePanz it's rebased on master branch and ready to merge. Build test passes without cache. ``` docker-compose build --no-cache ```
Rebased on `master` branch
sfValidatorDate throws sfValidatorError with array as $value and therefore not usable in the message
Yes, let's go this way. I suggest being more strict. As, the value will be displayed to end-users. And input value is going from end-users too. 1. To avoid the...
Same issue for `sfMySQLSessionStorage` and its neighbour `sfMySQLiDatabase`, `sfMySQLiSessionStorage`. `php test/unit/storage/sfMySQLStorageTest.php` 