Alexandre Quercia

Results 141 comments of Alexandre Quercia

A small joke. Lime is lying. The main motivation for #301 is to convert lime to tell the truth. Actual behaviour it's surprising.

@thePanz I have done a patch there https://github.com/FriendsOfSymfony1/symfony1/pull/302/files#diff-5d71b552c7a0ef74e4a9d348d29f677871db2cd0b8098308d94932d87b030dbd

Good idea. Another idea without composer dependency. But using `ReflectionClass`. It avoids plugin duplication > we should not allow composer/installers 1.0 to be in the dependencies, because this will duplicate...

### Like a feature flag The overall test suite should pass when the feature flag is enabled or disabled. Regarding this principle, a failed test should always fail the job....

@thePanz hey, I got it tests passes on GitHub action. Let me know whether this PR has any chance to be merged.

Rebased on master branch

> This patch is also included in #302, isn't it? Yes, but, I suggest merging this one before #302.

@thePanz thanks for your review. Mainly, your feedbacks are only about having better code structure. So I will proceed with fixing code structure. Then I will ping you when done.

After rebase on `master` branch, I got this error. ```sh $ test/bin/test + docker-compose build ERROR: The Compose file is invalid because: Service php81 has neither an image nor a...

It was not only about code structure, but the behavior has been exposed with the proof that work as expected (tests). The current tests that failed introduce the fact that...