symfony1 icon indicating copy to clipboard operation
symfony1 copied to clipboard

Add support for SameSite session cookies

Open mentalstring opened this issue 6 years ago • 6 comments

Starting from PHP 7.3 there's native support for SameSite cookies (RFC6265bis) which requires using a new session_get_cookie_params() parameter syntax.

mentalstring avatar Nov 22 '19 16:11 mentalstring

Maybe add sfWebResponse->setCookie to be feature complete?

michilehr avatar Nov 22 '19 17:11 michilehr

It looks like this PR was never merged. @alquerci does this just need a PHP-7.3-specific test in sfWebResponseTest.php?

mkopinsky avatar Aug 28 '23 15:08 mkopinsky

It looks like this PR was never merged. @alquerci does this just need a PHP-7.3-specific test in sfWebResponseTest.php?

@mkopinsky yes The idea is the following: Write the test that forces you to write the code you already know you want to write.

@thePanz can you tell us what is the minimum PHP version supported now ?

alquerci avatar Aug 28 '23 18:08 alquerci

@alquerci @mkopinsky (damn, that's quite an old ticket :sweat_smile: )

My plan is to move to PHP v7.4 as min version as a first step. ... and later to require PHP v8.1 as min version by removing all PHP v5.x and 7.x support

WDYT?

thePanz avatar Nov 17 '23 08:11 thePanz

@thePanz I think that make sf1 compatible with latest PHP version is another topic than removing support for old PHP versions.

What problem will be fixed by removing all PHP v5.x and 7.x support?

My point of view

We should be able to have information about the usage of sf1 in terms of, at least:

  • PHP version used
  • sf1 version used

Because the segment of sf1 usage is the main target of the purpose of the support provided by FriendsOfSymfony1.

The main goal is to provide an easy path to migrate to the latest Symfony LTS version, or at least the first Symfony2 version. "at least the first Symfony2 version" because Symfony2 itself have a migration path.

Nothing new as FriendsOfSymfony1 organization what next? #201

Provide a list of instructions how to switch from symfony 1.4.20 to FriendsOfSymfony1 #244 is the first step, the next one is from FriendsOfSymfony1 to Symfony2+

Do you agree with that goal?

What I know

  • Removing PHP <=7.2 version support will block the migration to Symfony 2.8.
    • Because Symfony 2.8 supports PHP >=5.3.2 <=7.2
Symfony version PHP version supported
1.4 5.2 <= version <= 5.3
1.5.15 5.3 <= version <= 8.2
1.5.16-dev 7.1 <= version <= 8.2
2.8 5.3.2 <= version <= 7.2
3.4 5.5.9 <= version <= 7.4
4.4 7.1.3 <= version <= 7.4
6.4 8.1 <= version <= 8.2

Hypothesis

  • Does migrate from sf1.4 to latest Symfony version is possible? Who did it?
  • Does migrate from FriendsOfSymfony1 to Symfony2 is possible?

That's why, like a production management, we need to know users of sf1.

alquerci avatar Nov 18 '23 18:11 alquerci

Removing PHP <=7.2 version support will block the migration to Symfony 2.8

Who wants to migrate to an unsupported outdated version of symfony?

connorhu avatar Nov 29 '23 07:11 connorhu